refactor: Extract NumericIds from PickerId for reusable ID generation#8482
Merged
mvaligursky merged 1 commit intomainfrom Feb 26, 2026
Merged
refactor: Extract NumericIds from PickerId for reusable ID generation#8482mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
Add NumericIds class (src/core/numeric-ids.js) as a general-purpose sequential ID generator that supports multiple independent instances. Refactor PickerId to be a pre-created NumericIds instance, preserving the existing API. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NumericIdsclass (src/core/numeric-ids.js) — a general-purpose sequential numeric ID generator that supports multiple independent instancesPickerIdto be a pre-createdNumericIdsinstance, preserving the existingPickerId.get()API with no changes needed at call sites