fix: Inline WGSL resolveCodebook to fix Firefox naga compatibility#8450
Merged
mvaligursky merged 1 commit intomainfrom Feb 9, 2026
Merged
fix: Inline WGSL resolveCodebook to fix Firefox naga compatibility#8450mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
Firefox's naga WGSL compiler rejects ptr<uniform, ...> as a function parameter per the WGSL spec. Inline the codebook resolution at all call sites to directly access uniform arrays without passing pointers. Co-authored-by: Cursor <cursoragent@cursor.com>
mvaligursky
added a commit
that referenced
this pull request
Feb 9, 2026
…8450) Firefox's naga WGSL compiler rejects ptr<uniform, ...> as a function parameter per the WGSL spec. Inline the codebook resolution at all call sites to directly access uniform arrays without passing pointers. Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveCodebookfunction at all 3 call sites to fix Firefox WebGPU shader validation errorsptr<uniform, ...>as a function parameter per the WGSL spec (onlyfunction,private, andworkgroupaddress spaces are allowed for pointer parameters)Files changed
src/scene/shader-lib/wgsl/chunks/gsplat/frag/gsplatPacking.js— RemovedresolveCodebookfunctionsrc/scene/shader-lib/wgsl/chunks/gsplat/frag/gsplatSogReorder.js— Inlined codebook resolution forscales_codebookandsh0_codebooksrc/scene/shader-lib/wgsl/chunks/gsplat/frag/gsplatSogReorderSh.js— Inlined codebook resolution forshN_codebookTest plan
Made with Cursor